Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api #373

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Fix api #373

merged 5 commits into from
Aug 18, 2023

Conversation

ermalkaleci
Copy link
Collaborator

No description provided.

@ermalkaleci ermalkaleci merged commit bf91870 into master Aug 18, 2023
4 checks passed
@ermalkaleci ermalkaleci deleted the fix-api branch August 18, 2023 17:18
@@ -42,13 +42,13 @@ export class RemoteStorageLayer implements StorageLayerProvider {
if (this.#db) {
const res = await keyValuePair?.findOne({ where: { key, blockHash: this.#at } })
if (res) {
return res.value
return res.value ?? undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?? undefined? that's a nop

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Db returns null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryFailedError: SQLITE_CONSTRAINT: NOT NULL constraint failed: key_value_pair.blockHash
2 participants